search

mitodl / ocw-www

Other
0 stars 0 forks source link

Back button doesn't work in search #94

Closed pdpinch closed 3 years ago

pdpinch commented 3 years ago

Steps to Reproduce

  1. Go to https://ocwnext.odl.mit.edu/search/
  2. Search for "Monday" (for example)
  3. Browser URL updates to https://ocwnext.odl.mit.edu/search/?q=monday
  4. Search for "Tuesday" (for example)
  5. Browser URL updates to https://ocwnext.odl.mit.edu/search/?q=tuesday
  6. Click the back button

Expected Behavior

Actual Behavior

noisecapella commented 3 years ago

@pdpinch Do we want this behavior for open-discussions search too?

pdpinch commented 3 years ago

Yes, especially if it’s easier to keep it consistent.

The back button should always work, right?

noisecapella commented 3 years ago

Yes, since the change is in course-search-utils it would be easier to do both. Though it won't update for open-discussions until we choose to upgrade versions

noisecapella commented 3 years ago

The basic functionality is working but it looks like clicking the back button to leave the search page is broken, so I'm looking into fixing that