mitodl / ocw-www

Other
0 stars 0 forks source link

do some webp conversion, to reduce loading times #98

Closed alicewriteswrongs closed 3 years ago

alicewriteswrongs commented 3 years ago

Pre-Flight checklist

What are the relevant tickets?

closes #97

What's this PR do?

converts a bunch of key images over to webp format from png or jpeg.

How should this be manually tested?

the site should look normal and the same as on the main branch. I don't think I messed anything up when converting images, but it's certainly possible and so good to test!

screens:

Screen Shot 2021-04-16 at 10 49 33 AM

github-actions[bot] commented 3 years ago

🚀 Deployed on https://ocw-www-pr-98--ocw-next.netlify.app

github-actions[bot] commented 3 years ago

Lighthouse results:

results for https://ocw-www-pr-98--ocw-next.netlify.app/:

Accessibility Best Practices Performance Progressive Web App SEO
72 🙂 80 😄 34 😰 42 😨 62 😐

results for https://ocw-www-pr-98--ocw-next.netlify.app/search/:

Accessibility Best Practices Performance Progressive Web App SEO
71 🙂 93 🎉 78 🙂 42 😨 55 😟
gumaerc commented 3 years ago

I'm not sure exactly what the cause would be, but this seems to have actually decreased performance on the home page? This is a screenshot of a lighthouse run from the most recent PR merged here:

chrome_2021-04-16_12-31-46

gumaerc commented 3 years ago

For what it's worth, this is what I get running lighthouse in an incognito window locally:

chrome_2021-04-16_12-44-34