Closed Ardiea closed 1 year ago
Merging #1004 (ce28460) into master (1be76e2) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #1004 +/- ##
=======================================
Coverage 96.03% 96.03%
=======================================
Files 182 182
Lines 7345 7345
Branches 251 251
=======================================
Hits 7054 7054
Misses 257 257
Partials 34 34
Impacted Files | Coverage Δ | |
---|---|---|
odl_video/settings.py | 87.77% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
Tweaking the application settings to allow celery and redbeat to use TLS when connecting to Redis/Elasticache.
Pre-Flight checklist
app.json
What are the relevant tickets?
https://github.com/mitodl/ol-infrastructure/issues/1099
What's this PR do?
Documents an explicit distinction between REDIS_URL and CELERY_BROKER_URL and when they can be same (no TLS) and when the must diverge (using TLS) as well as the nature of that divergence.
Additionally updates celery-redbeat from a really old version to just an old version (but the newest available...)
How should this be manually tested?
... Might be tricky without REDIS+TLS. It would be good to verify that non-TLS setups continue to work by setting REDIS_URL.
TLS is straight forward and the default in AWS and it comes with a verifiable certificate. I can do a screenshare on a new QA environment that has REDIS+TLS if you want to see it in action.
Where should the reviewer start?
(Optional)
Any background context you want to provide?
(Optional)
Screenshots (if appropriate)
(Optional)
What GIF best describes this PR or how it makes you feel?
(Optional)