search

mitodl / odl-video-service

building blocks for a basic video service for ODL
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

Convert to use Poetry for Python dependency management #1060

Closed blarghmatey closed 1 year ago

blarghmatey commented 1 year ago

Pre-Flight checklist

What are the relevant tickets?

N/A

What's this PR do?

Convert to use Poetry for Python package management

How should this be manually tested?

CI tests should pass You should be able to run the app locally as before, and it should work the same as before: docker-compose up docker-compose run --rm web pytest . docker-compose run --rm web python manage.py shell etc.

Where should the reviewer start?

pyproject.toml

Any background context you want to provide?

https://github.com/mitodl/hq/discussions/1422

mbertrand commented 1 year ago

@Ardiea does the removal of requirements.txt have implications for how OVS is deployed to RC and production?

Ardiea commented 1 year ago

Yeah, but Tobias has already accounted for it here with the appropriate updates to the Dockerfile.

ChristopherChudzicki commented 1 year ago

@Ardiea Does heroku use the Dockerfile?