search

mitodl / odl-video-service

building blocks for a basic video service for ODL
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

Update dependency webpack-dev-middleware to v5 [SECURITY] #1085

Closed renovate[bot] closed 3 months ago

renovate[bot] commented 5 months ago

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
webpack-dev-middleware ^3.7.2 -> ^5.0.0 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-29180

Summary

The webpack-dev-middleware middleware does not validate the supplied URL address sufficiently before returning the local file. It is possible to access any file on the developer's machine.

Details

The middleware can either work with the physical filesystem when reading the files or it can use a virtualized in-memory memfs filesystem. If writeToDisk configuration option is set to true, the physical filesystem is used: https://github.com/webpack/webpack-dev-middleware/blob/7ed24e0b9f53ad1562343f9f517f0f0ad2a70377/src/utils/setupOutputFileSystem.js#L21

The getFilenameFromUrl method is used to parse URL and build the local file path. The public path prefix is stripped from the URL, and the unsecaped path suffix is appended to the outputPath: https://github.com/webpack/webpack-dev-middleware/blob/7ed24e0b9f53ad1562343f9f517f0f0ad2a70377/src/utils/getFilenameFromUrl.js#L82 As the URL is not unescaped and normalized automatically before calling the midlleware, it is possible to use %2e and %2f sequences to perform path traversal attack.

PoC

A blank project can be created containing the following configuration file webpack.config.js: module.exports = { devServer: { devMiddleware: { writeToDisk: true } } };

When started, it is possible to access any local file, e.g. /etc/passwd: $ curl localhost:8080/public/..%2f..%2f..%2f..%2f../etc/passwd

root:x:0:0:root:/root:/bin/bash
daemon:x:1:1:daemon:/usr/sbin:/usr/sbin/nologin
bin:x:2:2:bin:/bin:/usr/sbin/nologin
sys:x:3:3:sys:/dev:/usr/sbin/nologin
sync:x:4:65534:sync:/bin:/bin/sync
games:x:5:60:games:/usr/games:/usr/sbin/nologin

Impact

The developers using webpack-dev-server or webpack-dev-middleware are affected by the issue. When the project is started, an attacker might access any file on the developer's machine and exfiltrate the content (e.g. password, configuration files, private source code, ...).

If the development server is listening on a public IP address (or 0.0.0.0), an attacker on the local network can access the local files without any interaction from the victim (direct connection to the port).

If the server allows access from third-party domains (CORS, *_Allow-Access-Origin: _** ), an attacker can send a malicious link to the victim. When visited, the client side script can connect to the local server and exfiltrate the local files.

Recommendation

The URL should be unescaped and normalized before any further processing.

Release Notes

webpack/webpack-dev-middleware (webpack-dev-middleware) ### [`v5.3.4`](https://togithub.com/webpack/webpack-dev-middleware/releases/tag/v5.3.4) [Compare Source](https://togithub.com/webpack/webpack-dev-middleware/compare/v5.3.3...v5.3.4) ##### [5.3.4](https://togithub.com/webpack/webpack-dev-middleware/compare/v5.3.3...v5.3.4) (2024-03-20) ##### Bug Fixes - **security:** do not allow to read files above ([#​1779](https://togithub.com/webpack/webpack-dev-middleware/issues/1779)) ([189c4ac](https://togithub.com/webpack/webpack-dev-middleware/commit/189c4ac7d2344ec132a4689e74dc837ec5be0132)) ### [`v5.3.3`](https://togithub.com/webpack/webpack-dev-middleware/blob/HEAD/CHANGELOG.md#533-2022-05-18) [Compare Source](https://togithub.com/webpack/webpack-dev-middleware/compare/v5.3.2...v5.3.3) ### [`v5.3.2`](https://togithub.com/webpack/webpack-dev-middleware/blob/HEAD/CHANGELOG.md#532-2022-05-17) [Compare Source](https://togithub.com/webpack/webpack-dev-middleware/compare/v5.3.1...v5.3.2) ### [`v5.3.1`](https://togithub.com/webpack/webpack-dev-middleware/blob/HEAD/CHANGELOG.md#531-2022-02-01) [Compare Source](https://togithub.com/webpack/webpack-dev-middleware/compare/v5.3.0...v5.3.1) ### [`v5.3.0`](https://togithub.com/webpack/webpack-dev-middleware/blob/HEAD/CHANGELOG.md#530-2021-12-16) [Compare Source](https://togithub.com/webpack/webpack-dev-middleware/compare/v5.2.2...v5.3.0) ##### Features - added types ([a2fa77f](https://togithub.com/webpack/webpack-dev-middleware/commit/a2fa77f87ad4d9912d08a68624e41380821d4d10)) - removed cjs wrapper ([#​1146](https://togithub.com/webpack/webpack-dev-middleware/issues/1146)) ([b6d53d3](https://togithub.com/webpack/webpack-dev-middleware/commit/b6d53d3f4d43c4c0e646e8d06355f3b4c9893a4f)) ##### [5.2.2](https://togithub.com/webpack/webpack-dev-middleware/compare/v5.2.1...v5.2.2) (2021-11-17) ##### Chore - update `schema-utils` package to `4.0.0` version ##### [5.2.1](https://togithub.com/webpack/webpack-dev-middleware/compare/v5.2.0...v5.2.1) (2021-09-25) - internal release, no visible changes and features ### [`v5.2.2`](https://togithub.com/webpack/webpack-dev-middleware/blob/HEAD/CHANGELOG.md#522-2021-11-17) [Compare Source](https://togithub.com/webpack/webpack-dev-middleware/compare/v5.2.1...v5.2.2) ### [`v5.2.1`](https://togithub.com/webpack/webpack-dev-middleware/blob/HEAD/CHANGELOG.md#521-2021-09-25) [Compare Source](https://togithub.com/webpack/webpack-dev-middleware/compare/v5.2.0...v5.2.1) - internal release, no visible changes and features ### [`v5.2.0`](https://togithub.com/webpack/webpack-dev-middleware/releases/tag/v5.2.0) [Compare Source](https://togithub.com/webpack/webpack-dev-middleware/compare/v5.1.0...v5.2.0) ##### Features - allow array for `headers` option ([#​1042](https://togithub.com/webpack/webpack-dev-middleware/issues/1042)) ([5a6a3f0](https://togithub.com/webpack/webpack-dev-middleware/commit/5a6a3f0f8e6b0f8fef33629f0f6fa5bed545a88c)) ### [`v5.1.0`](https://togithub.com/webpack/webpack-dev-middleware/blob/HEAD/CHANGELOG.md#510-2021-09-09) [Compare Source](https://togithub.com/webpack/webpack-dev-middleware/compare/v5.0.0...v5.1.0) ##### Features - don't read full file if `Range` header is present ([e8b21f0](https://togithub.com/webpack/webpack-dev-middleware/commit/e8b21f0979c4807b28f7be45aff0d25cca1585ae)) - output more information on errors ([#​1024](https://togithub.com/webpack/webpack-dev-middleware/issues/1024)) ([7df9e44](https://togithub.com/webpack/webpack-dev-middleware/commit/7df9e449945a852622135f3f0857599ad7b8af64)) ##### Bug Fixes - reduced package size by removing `mem` package ([#​1027](https://togithub.com/webpack/webpack-dev-middleware/issues/1027)) ([0d55268](https://togithub.com/webpack/webpack-dev-middleware/commit/0d55268478f9cbba122855e2be9d7493350d4d5d)) ### [`v5.0.0`](https://togithub.com/webpack/webpack-dev-middleware/blob/HEAD/CHANGELOG.md#500-2021-06-02) [Compare Source](https://togithub.com/webpack/webpack-dev-middleware/compare/v4.3.0...v5.0.0) ##### ⚠ BREAKING CHANGES - minimum supported `Node.js` version is `12.13.0` ([#​928](https://togithub.com/webpack/webpack-dev-middleware/issues/928)) ([4cffeff](https://togithub.com/webpack/webpack-dev-middleware/commit/4cffeffb5fd07ea79e5a7a5a0cdb3f08f3856c06)) ### [`v4.3.0`](https://togithub.com/webpack/webpack-dev-middleware/blob/HEAD/CHANGELOG.md#430-2021-05-19) [Compare Source](https://togithub.com/webpack/webpack-dev-middleware/compare/v4.2.0...v4.3.0) ##### Features - add `getFilenameFromUrl` to API ([#​911](https://togithub.com/webpack/webpack-dev-middleware/issues/911)) ([1edc726](https://togithub.com/webpack/webpack-dev-middleware/commit/1edc7263ff62cfd6456f35e3cb3c2e30c3ac379a)) ##### Bug Fixes - husky config ([#​904](https://togithub.com/webpack/webpack-dev-middleware/issues/904)) ([8a423be](https://togithub.com/webpack/webpack-dev-middleware/commit/8a423bea3f1641e99c1f6fed56630bfe128b62d8)) - typo depandabot -> dependabot ([#​905](https://togithub.com/webpack/webpack-dev-middleware/issues/905)) ([7062990](https://togithub.com/webpack/webpack-dev-middleware/commit/7062990a55d21d2e35de832ea593f7b088bf054b)) ### [`v4.2.0`](https://togithub.com/webpack/webpack-dev-middleware/blob/HEAD/CHANGELOG.md#420-2021-05-10) [Compare Source](https://togithub.com/webpack/webpack-dev-middleware/compare/v4.1.0...v4.2.0) ##### Features - allow the `headers` option to accept function ([#​897](https://togithub.com/webpack/webpack-dev-middleware/issues/897)) ([966afb3](https://togithub.com/webpack/webpack-dev-middleware/commit/966afb3e331f09912bb9fc5f403e758f586b1a07)) ### [`v4.1.0`](https://togithub.com/webpack/webpack-dev-middleware/blob/HEAD/CHANGELOG.md#410-2021-01-15) [Compare Source](https://togithub.com/webpack/webpack-dev-middleware/compare/v4.0.4...v4.1.0) ##### Features - added the `stats` option ([376cdba](https://togithub.com/webpack/webpack-dev-middleware/commit/376cdba4b6d3f70414d3d1707f80539b7523e486)) ##### [4.0.4](https://togithub.com/webpack/webpack-dev-middleware/compare/v4.0.3...v4.0.4) (2021-01-13) ##### Bug Fixes - compatibility with webpack@4 ([#​816](https://togithub.com/webpack/webpack-dev-middleware/issues/816)) ([acdfd4d](https://togithub.com/webpack/webpack-dev-middleware/commit/acdfd4d8b671ba98b601ea4d53c7dccea3270e73)) ##### [4.0.3](https://togithub.com/webpack/webpack-dev-middleware/compare/v4.0.1...v4.0.3) (2021-01-12) ##### Bug Fixes - output `stats` to `stdout` instead `stderr`, how does `webpack-cli`, if you need hide `stats` from output please use `{ stats: false }` or `{ stats: 'none' }` ([4de0f97](https://togithub.com/webpack/webpack-dev-middleware/commit/4de0f97596d52a7182ac108a9b9865462fca54fe)) - colors are working for `stats` ([4de0f97](https://togithub.com/webpack/webpack-dev-middleware/commit/4de0f97596d52a7182ac108a9b9865462fca54fe)) - schema description ([#​783](https://togithub.com/webpack/webpack-dev-middleware/issues/783)) ([f9ce2b2](https://togithub.com/webpack/webpack-dev-middleware/commit/f9ce2b2537c331901e230c5a8452f4b91d45c713)) - skip `Content-type header` on unknown types ([#​809](https://togithub.com/webpack/webpack-dev-middleware/issues/809)) ([5c9eee5](https://togithub.com/webpack/webpack-dev-middleware/commit/5c9eee549be264f6df202d960b7cd10bfff7f97d)) ##### [4.0.2](https://togithub.com/webpack/webpack-dev-middleware/compare/v4.0.1...v4.0.2) (2020-11-10) ##### Bug Fixes - compatibility with the `headers` option ([#​763](https://togithub.com/webpack/webpack-dev-middleware/issues/763)) ([7c4cac5](https://togithub.com/webpack/webpack-dev-middleware/commit/7c4cac538dc7facf3c3334863ec3a49b14e16630)) ##### [4.0.1](https://togithub.com/webpack/webpack-dev-middleware/compare/v4.0.0...v4.0.1) (2020-11-09) ##### Bug Fixes - compatibility with `connect` ([b83a1db](https://togithub.com/webpack/webpack-dev-middleware/commit/b83a1db264b4fb50361264cf98f102b34413bfaa)) ### [`v4.0.4`](https://togithub.com/webpack/webpack-dev-middleware/blob/HEAD/CHANGELOG.md#404-2021-01-13) [Compare Source](https://togithub.com/webpack/webpack-dev-middleware/compare/v4.0.3...v4.0.4) ### [`v4.0.3`](https://togithub.com/webpack/webpack-dev-middleware/blob/HEAD/CHANGELOG.md#403-2021-01-12) [Compare Source](https://togithub.com/webpack/webpack-dev-middleware/compare/v4.0.2...v4.0.3) ### [`v4.0.2`](https://togithub.com/webpack/webpack-dev-middleware/blob/HEAD/CHANGELOG.md#402-2020-11-10) [Compare Source](https://togithub.com/webpack/webpack-dev-middleware/compare/v4.0.1...v4.0.2) ### [`v4.0.1`](https://togithub.com/webpack/webpack-dev-middleware/blob/HEAD/CHANGELOG.md#401-2020-11-09) [Compare Source](https://togithub.com/webpack/webpack-dev-middleware/compare/v4.0.0...v4.0.1) ### [`v4.0.0`](https://togithub.com/webpack/webpack-dev-middleware/blob/HEAD/CHANGELOG.md#400-2020-10-28) [Compare Source](https://togithub.com/webpack/webpack-dev-middleware/compare/v3.7.3...v4.0.0) ##### ⚠ BREAKING CHANGES - export in CommonJS format ##### Bug Fixes - compatibility with new webpack@5 API ([#​737](https://togithub.com/webpack/webpack-dev-middleware/issues/737)) ([f6054a0](https://togithub.com/webpack/webpack-dev-middleware/commit/f6054a00e0e804a9d9ef0f4b3075e6116fae6c99)) - handle the `auto` value of the `publicPath` option ([9b4c5ec](https://togithub.com/webpack/webpack-dev-middleware/commit/9b4c5ec924d8b25d374b95433191d549f9d3717f)) - support webpack@5 ([#​702](https://togithub.com/webpack/webpack-dev-middleware/issues/702)) ([9ccc327](https://togithub.com/webpack/webpack-dev-middleware/commit/9ccc3276466754bb10e7f5d0b76f63de2a913e92)) ### [`v3.7.3`](https://togithub.com/webpack/webpack-dev-middleware/releases/tag/v3.7.3) [Compare Source](https://togithub.com/webpack/webpack-dev-middleware/compare/v3.7.2...v3.7.3) ##### [3.7.3](https://togithub.com/webpack/webpack-dev-middleware/compare/v3.7.2...v3.7.3) (2020-12-15) ##### Bug Fixes - peer dependencies with webpack@5 ([#​798](https://togithub.com/webpack/webpack-dev-middleware/issues/798)) ([71b2bdf](https://togithub.com/webpack/webpack-dev-middleware/commit/71b2bdf))

Configuration

📅 Schedule: Branch creation - "" in timezone US/Eastern, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

This PR has been generated by Mend Renovate. View repository job log here.