search

mitodl / odl-video-service

building blocks for a basic video service for ODL
BSD 3-Clause "New" or "Revised" License
4 stars 1 forks source link

Update 404 and 403 error to handle TechTV URLs #617

Closed pdpinch closed 6 years ago

pdpinch commented 6 years ago

As a user who was following a TechTV link, it would be reassuring if the error message acknowledged that the collection and/or video I am looking for is no longer available.

Current message: "This is a 404 error. This is not the page you were looking for."

Proposed new message: "This is a 404 error. This is not the page you were looking for. If you are looking for a video or collection, it is no longer available for viewing"

pdpinch commented 6 years ago

@mbertrand I see a PR for 404 errors, but none for 403. Do we ever return a 403?

mbertrand commented 6 years ago

The API will return a 403 for authenticated users that don't have permission to see a video.

screen shot 2018-05-16 at 1 38 23 pm
pdpinch commented 6 years ago

I think that's good enough -- although the line breaks are awkward