search

mitodl / ol-data-platform

Pipeline definitions for managing data flows to power analytics at MIT Open Learning
BSD 3-Clause "New" or "Revised" License
36 stars 6 forks source link

remove b2b and fix pk of orders mart #1199

Closed KatelynGit closed 1 month ago

KatelynGit commented 1 month ago

What are the relevant tickets?

https://github.com/mitodl/hq/issues/4296

Description (What does it do?)

This changes the code so that the primary key of the martscombinedorders table is generated via a reusable macro that can easily be added to other tables for joining. It also removed the b2b records and columns which will be put in a seperate table since they are not very common and only applicable to one platform.

How can this be tested?

dbt build --select martscombinedorders

pdpinch commented 1 month ago

I wish we had discussed removing the b2b orders before you worked on this. I'm not sure I agree with your reasoning about removing it.

But now that it's gone, I guess we can leave it out until we can discuss it with the accounts receivable finance team.