Closed rhysyngsun closed 6 months ago
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
@collinpreston I addressed most of your feedback, there are some things from the mockups that aren't feasible with theme changes or I left for other reasons, more details below:
6. When an email address is entered into the username-password form that does not match an existing Keycloak account, the error message displayed does not match the mock-ups.
I updated this to be as close as I can to the mock up, but I can't put a link in that message or dynamic information like the email address in there so I adapted the wording as best I can. I made Steve aware there are issues like this.
9. Should the text "©2024 Massachusetts Institute of Technology" be at the bottom of the pages? I don't see it in the mock-ups.
Asked on Slack, @pdpinch said we some kind of minimal footer, including copyright, at some point despite it not being in the mocks, so I'll leave this in.
10. The email-verification-sent page does not match the mock-up.
I looked into this, it can't be accomplished by templates, I didn't look into the feasibility but it would require a new Java customization if it can be done, that's out of scope for what I'm doing here. It's been asked a few times in various community forums and received no response as to how to even attempt it.
11. The formatting of the incorrect password error message on the username-password form does not match the mock-ups.
I updated this to be as close as I can to the mock up, but same as the email fields I can't put a link in that message so I carried over the "select Forgot Password below" wording. There's likely going to be more adjustments to the UX after I merge anyway, so this is probably fine for now.
12. The _show password_ button is shown on the username-password form.
This was intentional, there was a separate figma file from steve that noted this as a nice to have (#3 on second row): https://www.figma.com/file/M7raxNajixAyAB2MNfAB6l/MIT-Canvas?type=design&node-id=456-11513&mode=design
Thanks for enumerating those. I think they are fine for now (and maybe fine forever), so we can move ahead. I'm eager to test this on RC.
@collinpreston all set
What are the relevant tickets?
Part of https://github.com/mitodl/hq/issues/3473
Description (What does it do?)
This updates our theme to align to the current designs.
Screenshots (if appropriate):
How can this be tested?
Install the code changes:
ol-keycloak/oltheme
andol-keycloak/ol-spi
, runmvn clean install
target/
into your keycloak's/opt/keycloak/providers
directoryTest functionality:
Through this testing, double check that everything matches the designs.
Additional Context
Note that this is a fairly large amount of changes which is primarily due to the fact that our original theme was based on the base keycloak theme in 23.0. Keycloak 24.0 came out about 2 weeks ago removing that and replacing it with a more modern theme (v2). This required me to gut quite a bit of our theme and reapply the customizations on top of the new v2 theme.
Checklist: