If your realm didn't have the canonical home url set, this caused a template error
When that error happened, it cascaded into another error because the error page itself tries to use template.ftl and olSettings isn't defined for that. I updated the template to fail over to # for now in that situation because I haven't figured out how to inject values into the error page yet.
How can this be tested?
Similar testing of login, register, password reset, etc as before, although I largely haven't changed this code.
To test that the error page is working again, you can put in login.ftl a variable interpolation for one that doesn't exist (e.g. ${abc.def.ghi}), this should be enough to trigger the error page on that page since trying to throw an error explicitly from java doesn't work because of the method typings.
rhysyngsun
commented
3 months ago
What are the relevant tickets?
Part of #47
Description (What does it do?)
This PR includes:
template.ftlandolSettingsisn't defined for that. I updated the template to fail over to#for now in that situation because I haven't figured out how to inject values into the error page yet.How can this be tested?
login.ftla variable interpolation for one that doesn't exist (e.g.${abc.def.ghi}), this should be enough to trigger the error page on that page since trying to throw an error explicitly from java doesn't work because of the method typings.