Closed rhysyngsun closed 3 months ago
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
@collinpreston feedback is addressed
- Should the privacy policy hyperlink be shown twice on the registration page? It appears below the SAML providers and also in the footer.
The footer is common UI across all pages (it isn't in the designs, but I've asked before and we need it) and the additional link on the first message was in the designs. I agree it feels a bit off to have them repeated, especially with the visual proximity but I think it's something to have product/design folks address once these changes are in. I'll mention it so that it gets added to the designs so we can accommodate it correctly.
- Are first and last name expected to be required in the registration form?
Yes these are required.
- The tab order for the email-login page doesn't follow the visual order of elements on the page.
I stripped all the explicit tabindex
attributes since they're causing problems instead of value.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/4557
Description (What does it do?)
Screenshots (if appropriate):
[ ] Desktop screenshots
[ ] Mobile width screenshots
How can this be tested?