mitodl / ol-keycloak

Custom theme and extensions for Keycloak SSO
BSD 3-Clause "New" or "Revised" License
1 stars 0 forks source link

Update theme to match current designs #74

Closed rhysyngsun closed 3 months ago

rhysyngsun commented 3 months ago

What are the relevant tickets?

Closes https://github.com/mitodl/hq/issues/4557

Description (What does it do?)

Screenshots (if appropriate):

Screen Shot 2024-06-21 at 13 16 39 Screen Shot 2024-06-21 at 12 39 49

How can this be tested?

gitguardian[bot] commented 3 months ago

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | | | -------------- | ------------------ | ------------------------------ | ---------------- | --------------- | -------------------- | | [10049559](https://dashboard.gitguardian.com/workspace/71358/incidents/10049559?occurrence=150236035) | Triggered | Generic Password | de40f2b04260c528acebba6b05d6c3adacc98d6f | ol-keycloak/oltheme/src/main/resources/theme/ol/login/theme.properties | [View secret](https://github.com/mitodl/ol-keycloak/commit/de40f2b04260c528acebba6b05d6c3adacc98d6f#diff-d7edf8b20007c6760456c9042512ad8ba1a30370909d29684411a7d665819077L13) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secret safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/secrets-detection-engine/detectors/generics/generic_password#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

rhysyngsun commented 3 months ago

@collinpreston feedback is addressed

  1. Should the privacy policy hyperlink be shown twice on the registration page? It appears below the SAML providers and also in the footer.

The footer is common UI across all pages (it isn't in the designs, but I've asked before and we need it) and the additional link on the first message was in the designs. I agree it feels a bit off to have them repeated, especially with the visual proximity but I think it's something to have product/design folks address once these changes are in. I'll mention it so that it gets added to the designs so we can accommodate it correctly.

  1. Are first and last name expected to be required in the registration form?

Yes these are required.

  1. The tab order for the email-login page doesn't follow the visual order of elements on the page.

I stripped all the explicit tabindex attributes since they're causing problems instead of value.