mitodl / rapid-response-xblock

a django app plug-in for edx-platform

BSD 3-Clause "New" or "Revised" License

0 stars 2 forks source link

Added studio and XML doc references #113

Closed asadiqbal08 closed 2 years ago

asadiqbal08 commented 2 years ago

What are the relevant tickets?

fixes: #75

What's this PR do?

Updated the readme guide to include doc references for Studio and XML.

asadiqbal08 commented 2 years ago

@arslanashraf7 build failing over this PR is specific to changes in this PR ? https://github.com/mitodl/rapid-response-xblock/pull/111 ?

arslanashraf7 commented 2 years ago

@arslanashraf7 build failing over this PR is specific to changes in this PR ? #111 ?

Not really, but it's related to an import error and that import was made recently regarding signals(https://github.com/edx/edx-platform/commit/b6cb6298494c38d3aa9d336b217364b6818d4d14). Since we install packages from edx's requirements files so one of those packages is probably causing the issue because we are running the tests against Lilac branch of edX platform. Running the tests on master fixes the problem.

arslanashraf7 commented 2 years ago

Added a related comment on another PR that can fix the failing tests once merged. https://github.com/mitodl/rapid-response-xblock/pull/111/files#r728890729

codecov-commenter commented 2 years ago

Codecov Report

Merging #113 (6c350d7) into master (f4896cf) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #113   +/-   ##
=======================================
  Coverage   91.41%   91.41%           
=======================================
  Files          18       18           
  Lines         629      629           
  Branches       41       41           
=======================================
  Hits          575      575           
  Misses         50       50           
  Partials        4        4