mitodl / rapid-response-xblock

a django app plug-in for edx-platform
BSD 3-Clause "New" or "Revised" License
0 stars 2 forks source link

fix: Add anchor reference to scroll to & design tweaks #114

Closed arslanashraf7 closed 3 years ago

arslanashraf7 commented 3 years ago

What are the relevant tickets?

112

What's this PR do?

How should this be manually tested?

Check that the Rapid Response related functionality works fine within the Learning MFE - It would be a good idea to open a course with Multiple Choice Problem with Rapid Response enabled. Open the course in learning MFE and if you're an admin you'll see a button Legacy Experience(Open it in a new tab so that you can compare)

Where should the reviewer start?

Screenshots (if appropriate)

Open Problem Within MFE (BEFORE) -- Notice Double lined text -- If timer, warning and info messages are all shown together screencapture-localhost-2000-course-course-v1-Arbisoft-ARB-RR-0002-R1-block-v1-Arbisoft-ARB-RR-0002-R1-type-sequential-block-2daf3f5ea1194dc088cf89369660fc68-block-v1-Arbisoft-ARB-RR-0002-R1-type-vertical-block-44e675e69f2b41769473c24f2 (1)

Comparing Responses Within MFE (BEFORE) -- Notice Range/Date selecter getting outside the width screencapture-localhost-2000-course-course-v1-Arbisoft-ARB-RR-0002-R1-block-v1-Arbisoft-ARB-RR-0002-R1-type-sequential-block-2daf3f5ea1194dc088cf89369660fc68-block-v1-Arbisoft-ARB-RR-0002-R1-type-vertical-block-44e675e69f2b41769473c24f2 (2)

Comparing Responses Within MFE (AFTER) -- Notice the Selecter inside the container screencapture-localhost-2000-course-course-v1-Arbisoft-ARB-RR-0002-R1-block-v1-Arbisoft-ARB-RR-0002-R1-type-sequential-block-2daf3f5ea1194dc088cf89369660fc68-block-v1-Arbisoft-ARB-RR-0002-R1-type-vertical-block-44e675e69f2b41769473c24f2 (4)

Open Problem Within MFE (BEFORE) -- Single Lined Text screencapture-localhost-2000-course-course-v1-Arbisoft-ARB-RR-0002-R1-block-v1-Arbisoft-ARB-RR-0002-R1-type-sequential-block-2daf3f5ea1194dc088cf89369660fc68-block-v1-Arbisoft-ARB-RR-0002-R1-type-vertical-block-44e675e69f2b41769473c24f29e5c

View in Legacy Experience Comparison screencapture-localhost-18000-courses-course-v1-Arbisoft-ARB-RR-0002-R1-courseware-7e8253e9363c4199bdc6aaeda82b26f0-2daf3f5ea1194dc088cf89369660fc68-1-2021-10-14-21_53_46

Open Problem screencapture-localhost-18000-courses-course-v1-Arbisoft-ARB-RR-0002-R1-courseware-7e8253e9363c4199bdc6aaeda82b26f0-2daf3f5ea1194dc088cf89369660fc68-1-2021-10-14-21_58_55

arslanashraf7 commented 3 years ago

@pdpinch FYI, Along with Open/Close button's event problem there were some design regression as well within the Comparison selectors & Timer/info row on the top of xBlock which I have currently fixed with few tweaks in the CSS/HTML in padding & font size.

Could you take a look at the screenshots that have been added to the description and let me know what you'd think?

pdpinch commented 3 years ago

Thanks @arslanashraf7. The screenshots look OK to me.