mitodl / rapid-response-xblock

a django app plug-in for edx-platform
BSD 3-Clause "New" or "Revised" License
0 stars 2 forks source link

fix: update broken test settings and fix warnings #126

Closed arslanashraf7 closed 2 years ago

arslanashraf7 commented 2 years ago

What are the relevant tickets?

124

What's this PR do?

How should this be manually tested?

Where should the reviewer start?

Anyone reviewing should start with the code review and the parts where we are setting up our test data

Any background context you want to provide?

Mentioned in #124

Reviewer Note: If you wonder about anything in the PR, a look at this comment might help. Otherwise, let me know anyway.

codecov-commenter commented 2 years ago

Codecov Report

Merging #126 (fa8ba79) into master (27c4752) will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #126      +/-   ##
==========================================
+ Coverage   91.41%   91.42%   +0.01%     
==========================================
  Files          18       18              
  Lines         629      630       +1     
  Branches       41       54      +13     
==========================================
+ Hits          575      576       +1     
  Misses         50       50              
  Partials        4        4              
Impacted Files Coverage Δ
rapid_response_xblock/block.py 99.12% <100.00%> (ø)
rapid_response_xblock/logger.py 100.00% <100.00%> (ø)
tests/test_aside.py 100.00% <100.00%> (ø)
tests/utils.py 92.53% <100.00%> (+0.11%) :arrow_up: