mitodl / rapid-response-xblock

a django app plug-in for edx-platform
BSD 3-Clause "New" or "Revised" License
0 stars 2 forks source link

feat: add rapid response config setting in author view #138

Closed arslanashraf7 closed 11 months ago

arslanashraf7 commented 1 year ago

What are the relevant tickets?

https://github.com/mitodl/hq/issues/1960 Trial of Option#1 in https://github.com/mitodl/hq/issues/1960#issuecomment-1647845771

What's this PR do?

How should this be manually tested?

Where should the reviewer start?

Screenshots (if appropriate)

Studio Preview View

image

Studio Component/Plugin/Setting View

image
pdpinch commented 1 year ago

Interesting. I didn't know there was an authoring view for asides. Do you know of any other xBlocks or asides that use that?

I guess this will work (for now, at least), but it sidesteps the issue that the authoring MFE overlooked the plugin architecture.

arslanashraf7 commented 1 year ago

Interesting. I didn't know there was an authoring view for asides. Do you know of any other xBlocks or asides that use that?

As for the asides part, The tagging in edx uses this tagging xblock. And here is some document on author_view.

As for the usage in xBlocks, Here is some general usage within the edX and some xBlocks. e.g. LTI consumer xblock, Library root xblock

I guess this will work (for now, at least), but it sidesteps the issue that the authoring MFE overlooked the plugin architecture.

I agree, And https://github.com/openedx/frontend-app-course-authoring/issues/545 (along with some discussion) is the issue I created with them. They may probably add support for these for in Q release as per the response there.

arslanashraf7 commented 12 months ago

@pdpinch what do you suggest on:

Current Behavior:

As @asadali145 mentioned, Currently when we click the check box for rapid response in Course outline in studio, Users would have to refresh the page to see the Publish button or they would have to go back to the main course outline page and see an Up arrow to publish.

We have a couple of options to change this PR's current behavior:

Option 1: We do research to check if we can enable the studio's publish button when the rapid checkbox is checked, I'm not sure it this is possible at all, so this might need R&D. (This might be possible but would require some effort on the research part) Option 2: We auto-publish the problem when the rapid response checkbox is checked. (This one is quick)

@pdpinch What's your suggestion on above options?

pdpinch commented 12 months ago

Let's go ahead with autopublish.

However, I think we should plan to do a write up at some point about this whole PR, because it raises a lot of questions about xBlocks, Asides and Studio that I think we should bring to the open edX forums.

arslanashraf7 commented 12 months ago

😞 All the tests are breaking again. Probably something has changed in edX master branch against which we run our integration tests. I'm looking at it.

arslanashraf7 commented 12 months ago

So, I was able to track it down and it looks like this commit (that removes the old mongo functionality) broke it for us.

I suspect this might be complex, we might need to change the architecture of our tests to get them to pass again.

pdpinch commented 11 months ago

Oh boy. If it really is due to removal of old mongo, I think a open edX discussion post would be a good idea. I can ping Dave Ormsbee about it.

arslanashraf7 commented 11 months ago

I'll write some details in a discussion post.

arslanashraf7 commented 11 months ago

I'll write some details in a discussion post.

Forgot to reference it here. I created this discussion post in open edX and also got a response on that.

I'm going to merge this PR as is and create a separate ticket to fix the tests as per the suggestions given in this discussions post.