search

mitodl / rapid-response-xblock

a django app plug-in for edx-platform
BSD 3-Clause "New" or "Revised" License
0 stars 2 forks source link

Changed unknown error message UI from overlay to header text #67

Closed gsidebo closed 6 years ago

gsidebo commented 6 years ago

What are the relevant tickets?

Closes #66

What's this PR do?

Instead of showing a semi-transparent overlay with an error message, unexpected HTTP request errors will show some text in the header (as our timeout messages already do)

How should this be manually tested?

To replicate an unexpected error, the first argument to any call to makeAbortableRequest() in rapid.js can be changed to https://httpbin.org/status/500. Try that for various requests and ensure that the general error message is shown at the top of the rapid response content block, and that timeouts still show correctly (https://httpbin.org/delay/10 works if you want to test timeouts)

Screenshots (if appropriate)

Error on initial page load: ss 2018-08-10 at 16 16 20

Error during any request for problem responses or problem status changes: ss 2018-08-10 at 16 17 09

codecov-io commented 6 years ago

Codecov Report

Merging #67 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #67   +/-   ##
=======================================
  Coverage   90.01%   90.01%           
=======================================
  Files          15       15           
  Lines         561      561           
  Branches       34       34           
=======================================
  Hits          505      505           
  Misses         51       51           
  Partials        5        5

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f790cce...f2a141d. Read the comment docs.