search

mitodl / rapid-response-xblock

a django app plug-in for edx-platform
BSD 3-Clause "New" or "Revised" License
0 stars 2 forks source link

Travis to github #84

Closed arslanashraf7 closed 3 years ago

arslanashraf7 commented 3 years ago

What are the relevant tickets?

Fixes #82

What's this PR do?

Switches from Travis to Github actions.

How should this be manually tested?

Checking that all required parts are integrated & Github Actions pass successfully.

Where should the reviewer start?

Looking at the details of GitHub actions result page.

noisecapella commented 3 years ago

I think the test is failing because the docker mount point is incorrect. You just need to adjust your last line. Can you try changing $PWD/.. to $PWD/..:/rapid-response-xblock?

arslanashraf7 commented 3 years ago

I think the test is failing because the docker mount point is incorrect. You just need to adjust your last line. Can you try changing $PWD/.. to $PWD/..:/rapid-response-xblock?

@noisecapella Yes that makes sense, Let me give it a try.

noisecapella commented 3 years ago

In addition to the CapaDescriptor problem @gsidebo mentioned in a different PR it looks like pylint is erroring. That's coming from devstack so I'm not sure if master is just broken or if there's a dependency problem, if the problem is with Python 3.8 being used there, etc. One thing we could try is checking out a branch corresponding to a stable release branch rather than master

pdpinch commented 3 years ago

For our use, I think the most relevant branch for testing would be mitodl/mitx/koa

One thing we could try is checking out a branch corresponding to a stable release branch rather than master

arslanashraf7 commented 3 years ago

@pdpinch @noisecapella You are right.

Checking out the mitodl/mitx/koa on CI for tests fixed the pylint error that we were facing. There were many other issues other than CapaDescriptor as well that are fixed in a separate PR https://github.com/mitodl/rapid-response-xblock/pull/87 to keep the things tidy. (That separate PR does refactoring, and the build is passing there as well - After Koa branch checkout)

So, Once we go ahead & merge https://github.com/mitodl/rapid-response-xblock/pull/87. We can simply rebase this PR and this should be working as well.

pdpinch commented 3 years ago

87 is merged now. Is this unblocked?

arslanashraf7 commented 3 years ago

@pdpinch Yes, I have removed Blocked label from this.