gitguardian[bot]
commented
2 years ago ⚠️ GitGuardian has uncovered 8 secrets following the scan of your pull request.
Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.
🔎 Detected hardcoded secrets in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [2950715](https://dashboard.gitguardian.com/incidents/2950715?occurrence=48754555) | PostgreSQL Credentials | 86790d511aae0402b5c61ec470f46baffcbae056 | pillar/dagster/micromasters.sls | [View secret](https://github.com/mitodl/salt-ops/commit/86790d511aae0402b5c61ec470f46baffcbae056#diff-9b8b6c63a25772085ebad2dbc4fa1a215fda421c9d839d1130f3128400ed50b3L17) | | [4018557](https://dashboard.gitguardian.com/incidents/4018557?occurrence=48754556) | MongoDB Credentials | 86790d511aae0402b5c61ec470f46baffcbae056 | pillar/edx/ansible_vars/cloud_deployment.sls | [View secret](https://github.com/mitodl/salt-ops/commit/86790d511aae0402b5c61ec470f46baffcbae056#diff-79da6af3c1acd2e5e45c508e9fe37ec49860dd9ecb17eb06236ac6ee2a44df0bL146) | | [4018558](https://dashboard.gitguardian.com/incidents/4018558?occurrence=48754557) | MongoDB Credentials | 86790d511aae0402b5c61ec470f46baffcbae056 | pillar/edx/ansible_vars/cloud_deployment.sls | [View secret](https://github.com/mitodl/salt-ops/commit/86790d511aae0402b5c61ec470f46baffcbae056#diff-79da6af3c1acd2e5e45c508e9fe37ec49860dd9ecb17eb06236ac6ee2a44df0bL146) | | [4018559](https://dashboard.gitguardian.com/incidents/4018559?occurrence=48754558) | MongoDB Credentials | 86790d511aae0402b5c61ec470f46baffcbae056 | pillar/edx/ansible_vars/cloud_deployment.sls | [View secret](https://github.com/mitodl/salt-ops/commit/86790d511aae0402b5c61ec470f46baffcbae056#diff-79da6af3c1acd2e5e45c508e9fe37ec49860dd9ecb17eb06236ac6ee2a44df0bL146) | | [4018560](https://dashboard.gitguardian.com/incidents/4018560?occurrence=48754559) | Generic Database Assignment | 86790d511aae0402b5c61ec470f46baffcbae056 | pillar/edx/ansible_vars/cloud_deployment.sls | [View secret](https://github.com/mitodl/salt-ops/commit/86790d511aae0402b5c61ec470f46baffcbae056#diff-79da6af3c1acd2e5e45c508e9fe37ec49860dd9ecb17eb06236ac6ee2a44df0bL122) | | [4018561](https://dashboard.gitguardian.com/incidents/4018561?occurrence=48754560) | MongoDB Credentials | 86790d511aae0402b5c61ec470f46baffcbae056 | pillar/edx/ansible_vars/init.sls | [View secret](https://github.com/mitodl/salt-ops/commit/86790d511aae0402b5c61ec470f46baffcbae056#diff-97224cfcd4edd970f8bde79004c7dff38c32f6084861a61f8caaaad3dae735b9L72) | | [4018562](https://dashboard.gitguardian.com/incidents/4018562?occurrence=48754561) | MongoDB Credentials | 86790d511aae0402b5c61ec470f46baffcbae056 | pillar/edx/ansible_vars/init.sls | [View secret](https://github.com/mitodl/salt-ops/commit/86790d511aae0402b5c61ec470f46baffcbae056#diff-97224cfcd4edd970f8bde79004c7dff38c32f6084861a61f8caaaad3dae735b9L72) | | [4018563](https://dashboard.gitguardian.com/incidents/4018563?occurrence=48754562) | Generic Database Assignment | 86790d511aae0402b5c61ec470f46baffcbae056 | salt/edx/gitreload.sls | [View secret](https://github.com/mitodl/salt-ops/commit/86790d511aae0402b5c61ec470f46baffcbae056#diff-c51dc48c33531240cba529121d416a569779c316815a114d42a4f766ad47eaaeL39) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secrets safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate these secrets](https://docs.gitguardian.com/secrets-detection/detectors/specifics/postgres_assignment#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/internal-repositories-monitoring/integrations/git_hooks/pre_commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
We have migrated a large number of services to no longer depend on Salt. This removes code that is not relied on by any running systems to avoid wasted effort trying to understand logic that is no longer relevant.