search

mitodl / salt-ops

Repository for building, managing and deploying salt-based infrastructure
BSD 3-Clause "New" or "Revised" License
47 stars 7 forks source link

First pass at refactoring secrets #1588

Closed shaidar closed 1 year ago

shaidar commented 1 year ago

What are the relevant tickets?

Part of https://github.com/mitodl/ol-infrastructure/issues/1683

Description (What does it do?)

Refactor bootcamps secrets to use new vault kv v2 mounts and removed any references to environment.

gitguardian[bot] commented 1 year ago

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
| GitGuardian id | Secret | Commit | Filename | | | -------------- | ------------------------- | ---------------- | --------------- | -------------------- | | [8188119](https://dashboard.gitguardian.com/incidents/8188119?occurrence=115420400) | Company Email Password | a9ee20c0e06fac6b47619d9b38720b73b41c729b | pillar/heroku/bootcamps.sls | [View secret](https://github.com/mitodl/salt-ops/commit/a9ee20c0e06fac6b47619d9b38720b73b41c729b#diff-ff755dda6f5bb111cced135567a6dc3efa7fe641a5c01e61b6b6d4d94e5eab10L99) |
🛠 Guidelines to remediate hardcoded secrets
1. Understand the implications of revoking this secret by investigating where it is used in your code. 2. Replace and store your secret safely. [Learn here](https://blog.gitguardian.com/secrets-api-management?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) the best practices. 3. Revoke and [rotate this secret](https://docs.gitguardian.com/secrets-detection/detectors/generics/company_email_password#revoke-the-secret?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). 4. If possible, [rewrite git history](https://blog.gitguardian.com/rewriting-git-history-cheatsheet?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment). Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data. To avoid such incidents in the future consider - following these [best practices](https://blog.gitguardian.com/secrets-api-management/?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) for managing and storing secrets including API keys and other credentials - install [secret detection on pre-commit](https://docs.gitguardian.com/ggshield-docs/integrations/git-hooks/pre-commit?utm_source=product&utm_medium=GitHub_checks&utm_campaign=check_run_comment) to catch secret before it leaves your machine and ease remediation.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!