Refactor find etc - Githubissues

mitra42 / webForth

Forth for the web - implemented in JS and other web technologies

https://www.mitra.biz/forth/console.html

GNU Affero General Public License v3.0

27 stars 1 forks source link

Refactor find etc #84

Closed mitra42 closed 3 years ago

mitra42 commented 3 years ago

Have :

_find (va a -- na | 0)
find = jsFInd() a va -- ca na | a 0
findName() a -- xt na | a 0
NAME? a -- xt na | a F

Refactor around: FIND-NAME-IN ( c-addr u wid -- nt | 0 ) FIND-NAME (c-addr u -- nt | 0) NAME>XT like xt2na() na -- xt note that in some FORTHs this will be NAME>INTERPRET or NAME>COMPILE IMMEDIATE? (na | F) FIND (caddr -- caddr 0 | xt 1(immed) | xt -1(not immed))

See: https://forth-standard.org/standard/core/FIND and https://forth-standard.org/proposals/find-name#contribution-58

(At least partially Needed for #83 test suite)

mitra42 commented 3 years ago

Straw person (may get edited)

[x] _findNameIn(caddr, u, va -- na | 0)
[x] _find uses findNameIn
[x] FIND-NAME-IN
[x] find|jsFInd rewritted to use FIND-NAME-IN
[x] Split out FIND-NAME from NAME?
[x] NAME> replaces na2xt()
[x] immediate? (na -- F) uses code inside dCOMPILE, dINTERPRET etc which then use it
[x] FIND() build on FIND-NAME, IMMEDIATE? NAME>XT
[x] JStoXT dCOMPILE dINTERPRET tick etc gradually rewritten to use FIND() instead of jsFind
[x] $COMPILE $INTERPRET etc rewritten to use FIND instead of NAME?
[x] Backport code portions to Arduino

mitra42 commented 3 years ago

Some things not according to plan above, but all good. (Currently on Forth2012 branch just locally - will merge into master soon)