mitre-attack / attack-stix-data

STIX data representing MITRE ATT&CK
https://attack.mitre.org/
Other
308 stars 77 forks source link

Relationships microlibrary Filter argument #12

Closed Abadacor closed 2 years ago

Abadacor commented 2 years ago

Hello,

In the function _getrelated(...) from the relationships microlibrary code snippet in file USAGE.md the fourth filter creates a situation where variable relationships is always empty.

I haven't tested every possibility but I get this result with functions:

It appears that by only filtering out the revoked objects everything works just fine. I use the local data from file enterprise-attack.json for my work.

If someone could double check that'd be awesome.

PS: In the case I'm wrong there still is a mismatched quote with a double quote in that same line.

jondricek commented 2 years ago

@Abadacor - I know this issue is closed with the recent PR above, but I realized I never thanked you for pointing out the issue in the first place. Sorry about that! You were totally right about both the mismatched quote (fixed!) and the improper filtering. The filtering issue is actually resolved later in the USAGE document, but I implemented it in the section you mentioned and addressed it there.

If this works for you, great! And if you have any other suggestions, go ahead and let us know. Thanks again!