Closed AlaZegnani closed 1 year ago
I can confirm this bug and I think that I found the source of the problem:
Have a look at attack-pattern with id attack-pattern--970a3432-3237-47ad-bcca-7d8cbb217736
. As external sources it lists a source named inv_ps_attacks
.
This loop will look for the external_id
of all external sources of the attack patterns but will only check if attack
appears in the source name, which obviously is too unspecific and matches the object stated above. However, this source will not have an external_id
, since it is not coming from MITRE ATT&CK and therefore will raise an exception.
A possible solution would be to check specifically if the source name is mitre-attack
, but I am not familiar enough to know if this would break things elsewhere. If this is not acceptable, then we should possibly check if external_id
is present, but again I do not know if there are unwanted consequences if we do that 😄
If one of the maintainers can provide some guidance then I can prepare a pull request to fix this.
This issue was addressed in PR #95. Let us know if you still run into any problems.
Expected Behavior
I'm having trouble working with navlayers the error occurs when specifying taxii as source
source='taxii'
for example working with
LayerGeneratorcli
orUsageLayerGenerator
expected behaviour is getting a .json file as an outputBut running the following command:
Actual Behavior
layerGenerator_cli --domain enterprise --source taxii --mapped-to S0065 --output generated_layer.json
i get this error message instead
Steps to Reproduce the Problem
taxii
as source anywhere in navlayers causes this ( ToExcel, ToSvg matrix_gen ...)Possible Solution
A workaround could be working with local stix data but this is not an actual solution. It's basically specifying
(source='local',resource='stix_file.json')
.Plz note that this is my first time working with mitreattack-python so if i'm making a rookie mistake here i would really appreciate your help