Add CSV-file checks - Githubissues

mitre-attack / tram

Threat Report ATT&CK™ Mapping (TRAM) is a tool to aid analyst in mapping finished reports to ATT&CK.

Apache License 2.0

346 stars 66 forks source link

Add CSV-file checks #89

Closed jecarr closed 3 years ago

jecarr commented 3 years ago

Please Describe The Problem To Be Solved

Minor but the app currently allows any file to be selected for submitting bulk-reports.

Proposed Change

I have fixes - see tagged - but haven't created a PR due to maintaining #61. The approach is to:

Only allow .csv files to be selected (via the front-end)
- https://github.com/arachne-threat-intel/thread/commit/533784a10deddf1564725d18c6e4b04085ecf1e8#diff-72c881cf01f09ddabbbc5d6162b06e77983ed34d3b4afd5156691a556a48e92a
Also check via the server-side that the file can be parsed
- arachne-threat-intel/thread@d8dfe6f

MarkDavidson commented 3 years ago

Hello @jecarr and thank you for the bug report. TRAM has moved to https://github.com/center-for-threat-informed-defense/tram and this issue is no longer present in that repository so I am closing this issue. Thank you!