search

mitre-attack / tram

Threat Report ATT&CK™ Mapping (TRAM) is a tool to aid analyst in mapping finished reports to ATT&CK.
Apache License 2.0
346 stars 66 forks source link

Literal 'src=' breaks analysis #90

Closed jecarr closed 3 years ago

jecarr commented 3 years ago

Please Describe The Problem To Be Solved

Rare but a page may literally have the text 'src='. Example url. This breaks TRAM's analysis because during map_all_html(), 'src=' is considered an image element which then breaks soup.img['src'].

Proposed Change

I have a fix here - arachne-threat-intel/thread@9dd98bd - but haven't created a PR due to maintaining #61. The approach is to use BeautifulSoup's findAll() method for images. This will allow the code to continue even if an image is not found.

MarkDavidson commented 3 years ago

Hello @jecarr and thank you for the bug report. TRAM has moved to https://github.com/center-for-threat-informed-defense/tram and this issue is no longer present in that repository so I am closing this issue. Thank you!