search

mitre / HTTP-Proxy-Servlet

Smiley's HTTP Proxy implemented as a Java servlet
Apache License 2.0
1.47k stars 552 forks source link

Support for Web Sockets #145

Open twwwt opened 6 years ago

twwwt commented 6 years ago

I'm wondering whether the proxy servlet supports Web Sockets? I think the important thing is that it must not remove the headers Upgrade: WebSocket and Connection: Upgrade.

dsmiley commented 6 years ago

I don't know; but if you try it out then please support back. The proxy generally copies all headers on through.

geezer78 commented 7 months ago

Has anyone got this proxy servlet working with websockets (i use socket.io)? to my understanding it needs more than "just" pushing the hop-hop headers to the backend, i think you might need to create an actual socket tunnel? can anyone shed some light on this?

geezer78 commented 7 months ago

I see that akarnokd has done some work on adding proxy support see stackoverflow

i've tested this and it seems to work. could we incorporate this functionality?

dsmiley commented 7 months ago

As the maintainer here, mainly I want to see that what we add is tested. That's a key aspect to this proxy vs code snippets on Stackoverflow/blogs. So if you look at that and find a way to incorporate it and add tests, I'd be happy to peer review and ultimately merge.