search

mitre / canonical-ubuntu-18.04-lts-stig-baseline

(WIP) canonical-ubuntu-18.04-lts-stig-baseline
Other
9 stars 4 forks source link

Additional locking for terminals and desktop #13

Closed ghexp closed 3 years ago

ghexp commented 3 years ago

With proper upstreaming before PR

aaronlippold commented 3 years ago

This seems to be breaking the tests

ghexp commented 3 years ago

The error was not very informative as to the cause (being tied to PR). Is spec/results/ubuntu-18.04_hardened.json auto-generated? Did something change with inspec_tools?

/Users/runner/hostedtoolcache/Ruby/2.6.6/x64/lib/ruby/gems/2.6.0/gems/inspec_tools-2.3.2/lib/inspec_tools/summary.rb:29:in `read': No such file or directory @ rb_sysopen - spec/results/ubuntu-18.04_hardened.json

aaronlippold commented 3 years ago

Nope. It seems in this pool request there were some merge conflict data that was pushed. My guess is that the kitchen files for this PR are messed up

On Tue, Mar 2, 2021 at 7:27 PM Greg notifications@github.com wrote:

The error was not very informative as to the cause (being tied to PR). Is spec/results/ubuntu-18.04_hardened.json auto-generated? Did something change with inspec_tools?

/Users/runner/hostedtoolcache/Ruby/2.6.6/x64/lib/ruby/gems/2.6.0/gems/inspec_tools-2.3.2/lib/inspec_tools/summary.rb:29:in `read': No such file or directory @ rb_sysopen - spec/results/ubuntu-18.04_hardened.json

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/mitre/canonical-ubuntu-18.04-lts-stig-baseline/pull/13#issuecomment-789323528, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALK42CQ4HRTHDDSZNSJOH3TBV66TANCNFSM4YP425PQ .

--

Aaron Lippold

lippold@gmail.com

260-255-4779

twitter/aim/yahoo,etc. 'aaronlippold'

ghexp commented 3 years ago

I think I found it. Will attempt fix on that branch. Fixed the other issues in ansible for desktop

aaronlippold commented 3 years ago

The checks are passing, but there are merge conflicts in the defaults/main.yml that need to be resolved

aaronlippold commented 3 years ago

Do you know how to do that?

ghexp commented 3 years ago

Yep. I can resolve. I also need to make the updates for the describe/end if to if/else

aaronlippold commented 3 years ago

Cool

aaronlippold commented 3 years ago

Are you on Signal or Slack by the way?

aaronlippold commented 3 years ago

added you as an outside collaborator just in case you need it

aaronlippold commented 3 years ago

added you as an outside collaborator just in case you need it

You will need to accept the invite via email link

ghexp commented 3 years ago

Are you on Signal or Slack by the way?

I have a dormant slack account somewhere. If your Teams administrator would trust our domain, I think I could reach you that way

aaronlippold commented 3 years ago

Asking one of my folks to look at why the results files in the kitchen runs seem to be dying or getting overwritten and breaking the cicd

ghexp commented 3 years ago

Found it. Fixed. Missing 'end' (indent off) in inspec rule. Also 'unless' from CIS rule should have been 'if'

aaronlippold commented 3 years ago

Cool I will rerun the tests