mitre / canonical-ubuntu-18.04-lts-stig-baseline

(WIP) canonical-ubuntu-18.04-lts-stig-baseline
Other
9 stars 4 forks source link

Both manual and automated check for crypttab and root partition #29

Closed ghexp closed 3 years ago

ghexp commented 3 years ago

The 16.04 check was only manual but it is possible to compare cryttab to partition layout for default partition. Made the default manual review still.

ghexp commented 3 years ago

I did a quick scan and all the controls I saw have V-#s and SV-#s in the CCI list, so I assume that came from DISA that way on the import.

{{ var }} for the InSpec? Which line? I tested it locally and the json looked fine when testing it.

aaronlippold commented 3 years ago

Well, that must be a bug in the converter then if there are other V-# and SV-# in the CCI list. Totally different data element. We will have to fix that in the other controls.

No not an InSpec thing - it's a ruby thing - String interpolation.

name = "Ada"puts "Hello, #{name}!"

I will take a look at the other controls.

Aaron Lippold

@.***

260-255-4779

twitter/aim/yahoo,etc. 'aaronlippold'

On Sun, Mar 14, 2021 at 9:48 PM Greg @.***> wrote:

I did a quick scan and all the controls I saw have V-#s and SV-#s in the CCI list, so I assume that came from DISA that way on the import.

{{ var }} for the InSpec? Which line? I tested it locally and the json

looked fine when testing it.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mitre/canonical-ubuntu-18.04-lts-stig-baseline/pull/29#issuecomment-799035834, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALK42BMVGLW3O7JPLXV3MLTDVRP7ANCNFSM4ZFO2Z4A .

aaronlippold commented 3 years ago

Yup, your right, there is a bug in inspec-tools. I actually remember this popped up before.

Aaron Lippold

@.***

260-255-4779

twitter/aim/yahoo,etc. 'aaronlippold'

On Sun, Mar 14, 2021 at 9:57 PM Aaron Lippold @.***> wrote:

Well, that must be a bug in the converter then if there are other V-# and SV-# in the CCI list. Totally different data element. We will have to fix that in the other controls.

No not an InSpec thing - it's a ruby thing - String interpolation.

name = "Ada"puts "Hello, #{name}!"

I will take a look at the other controls.

Aaron Lippold

@.***

260-255-4779

twitter/aim/yahoo,etc. 'aaronlippold'

On Sun, Mar 14, 2021 at 9:48 PM Greg @.***> wrote:

I did a quick scan and all the controls I saw have V-#s and SV-#s in the CCI list, so I assume that came from DISA that way on the import.

{{ var }} for the InSpec? Which line? I tested it locally and the json

looked fine when testing it.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mitre/canonical-ubuntu-18.04-lts-stig-baseline/pull/29#issuecomment-799035834, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALK42BMVGLW3O7JPLXV3MLTDVRP7ANCNFSM4ZFO2Z4A .

aaronlippold commented 3 years ago

I think this has to do with the new data elements they added to the new stigs XCCDF file - bug reported here: https://github.com/mitre/inspec_tools/issues/220

ghexp commented 3 years ago

Speculating that single and double quotes are causing vanilla to fail somehow (but hardening succeeds? different version?). A couple examples in simp rules

aaronlippold commented 3 years ago

Yup Awk likes singles there

Aaron Lippold

@.***

260-255-4779

twitter/aim/yahoo,etc. 'aaronlippold'

On Sun, Mar 14, 2021 at 10:52 PM Greg @.***> wrote:

Speculating that single and double quotes are causing vanilla to fail somehow (but hardening succeeds? different version?). A couple examples in simp rules https://github.com/simp/inspec-profile-disa_stig-el7/blob/370ba605f10e12093e8048afcb58eaddf1243359/controls/V-72435.rb

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/mitre/canonical-ubuntu-18.04-lts-stig-baseline/pull/29#issuecomment-799054314, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALK42C4FP6MNJSKQ76E3OTTDVY7NANCNFSM4ZFO2Z4A .

aaronlippold commented 3 years ago

Speculating that single and double quotes are causing vanilla to fail somehow (but hardening succeeds? different version?). A couple examples in simp rules

I have usually seen singles used in the past there with awk and sed