search

mitre / cedar

Cedar is a tool for testing the strength of Electronic Clinical Quality Measure (eCQM) collection systems that receive Quality Reporting Document Architecture (QRDA) files. Please email opensource@mitre.org for more information.
8 stars 4 forks source link

On Cypress Measure Bundle #8

Open nickbabcock opened 8 years ago

nickbabcock commented 8 years ago

The Cypress measure bundle is needed for Cedar to function properly (as documented in the README). There should be steps in the build process (like ecqm's rakefile?) to add the bundle and a clear error messages when the bundle is missing.

If bundle hasn't been installed the following UI error message isn't helpful:

We're sorry, but something went wrong.

Even the log doesn't mention the bundle

NoMethodError (undefined method `id' for nil:NilClass):
  app/controllers/test_executions/steps_controller.rb:11:in `show'

After looking at the code, I finally realized my mistake :blush:

This is also relevant to the docker discussion, as one may have to pass in their NLM username and password as environment variables in order to build successfully.

notpace commented 8 years ago

Very timely - we've been working on a branch to address this for docker as part of the installation instructions - https://github.com/mitre/cedar/tree/docker_setup

At the same time, we're trying to figure out if we can safely eliminate the necessity for the NLM account by getting a fair use agreement signed for the codes used in the bundle. If we can work that out, we might be able to include much of that information in the repo (and then we wouldn't have to build bogus test fixtures, which I've been trying to avoid).

notpace commented 8 years ago

Unfortunately, we weren't able to eliminate the need for the NLM account, but I've added some language to the installation instructions in the README to help clarify this.