Review Postgres schema - Githubissues

mitre / heimdall-legacy

A Security Results Viewer for the web with storage, teams and history

https://heimdall-demo.mitre.org

Other

35 stars 15 forks source link

Open robthew opened 5 years ago

aaronlippold commented 5 years ago

We should add a description of goals. And we need to assign it to the crunchy data folks.

aaronlippold commented 5 years ago

@hunleyd have you had a chance to start on this review?

hunleyd commented 5 years ago

sadly no. it's still on my todo

hunleyd commented 5 years ago

prefer timestamptz fields always, not timestamp
prefer text over varchar
really shouldn't use reserved words as column names (e.g. "desc")
does it make sense to use default now() for some of these timestamps?
public.users.image is a varchar? is this a uuencoded image? otherwise, it should be a binary type, i think