mitre / heimdall2

Heimdall Enterprise Server 2 lets you view, store, and compare automated security control scan results.
Other
204 stars 61 forks source link

Rename package from Heimdall Tools to HDF Converters #4523

Open em-c-rod opened 1 year ago

em-c-rod commented 1 year ago

As an example:

import {version as HeimdallToolsVersion} from '../package.json';
...
platform: {
      name: 'Heimdall Tools',
      release: HeimdallToolsVersion
    },
    version: HeimdallToolsVersion,

Recommend changing to:

import {version as HDFConvertersVersion} from '../package.json';
...
platform: {
      name: 'HDF Converters',
      release: HDFConvertersVersion
    },
    version: HDFConvertersVersion,

Example below, but present in many converters: https://github.com/mitre/heimdall2/blob/master/libs/hdf-converters/src/burpsuite-mapper.ts#L82

Amndeep7 commented 1 year ago

some considerations we might need to keep in mind for some of the converters that have to handle like full-cycle situations (format -> hdf -> format / hdf -> format -> hdf) ex. ASFF

Amndeep7 commented 6 months ago

talked it out with @ejaronne, and "MITRE SAF OHDF Converters" is better with "MITRE SAF OHDF Converters Version" for the ckl export (and maybe other exports)