search

mitre / heimdall_tools

DEPRECATED: A set of utilities for converting and working with compliance data for viewing in the heimdall applications
https://heimdall-tools.mitre.org
Other
35 stars 20 forks source link

asff_mapper and prowler_mapper #104

Closed Amndeep7 closed 3 years ago

Bialogs commented 3 years ago

@Amndeep7 is this ready for review even though it is in draft?

Amndeep7 commented 3 years ago

@Bialogs I still need to flesh out the documentation, use aaron's account to make test data, and make a minor change to the prowler mapper, but otherwise yes for this portion. If we want to include the aws sdk mapper in this pr as well, then we can hold off until that's implemented, but that'll be sometime next week before I can work it.

@ejaronne ^

Amndeep7 commented 3 years ago

This force push was to rebase on top of master

Amndeep7 commented 3 years ago

And this force push is to do all the signoffs that I never remember to do

rx294 commented 3 years ago

The automated tests are failing on ruby 2.5, coz of the difference method.

Amndeep7 commented 3 years ago

The automated tests are failing on ruby 2.5, coz of the difference method.

Feels bad man. Thanks for figuring that out for me. I'll try to find a different method to use / write it myself.

Amndeep7 commented 3 years ago

Life is suffering. Now it seems like the hash type doesn't support filter in 2.5

Amndeep7 commented 3 years ago

Working with Ryan made me realize there was an issue in the nist_tag code. Will fix tonight.

rx294 commented 3 years ago

LGTM, thank you for making the updates. Merging.