search

mitre / heimdall_tools

DEPRECATED: A set of utilities for converting and working with compliance data for viewing in the heimdall applications
https://heimdall-tools.mitre.org
Other
35 stars 20 forks source link

WIP: Added initial support for scout suite #96

Closed Amndeep7 closed 3 years ago

Amndeep7 commented 3 years ago 
* Replace the examples with examples that are not so big

So the reason that the scoutsuite_sample.json is so big (20MB) is cause it has all the newlines/formatting put into it due to being prettified instead of all being on one line. This file as useful as a development tool but it's not necessary to store in the repo. Furthermore, it's easily reproducible when required (delete the first line and then run it through json formatter of choice).

If I delete that file, is it fine to leave the file we got directly from scoutsuite (4.5MB)? Still an order of magnitude more than the others (nikto/zap) but imo it's useful to have a complete file for testing/development purposes, and it's far less than what it was originally.

Amndeep7 commented 3 years ago

Besides the example files thing and any other comments from the reviewers, all that should be left is to rebase from current master to get rid of the conflicts which one would've thought would've been auto-resolvable considering that it's just more text in the list of text of that exact same format but git's throwing a fit regardless.

Edit: oh also, need to run the linter against it.

Bialogs commented 3 years ago 
* Replace the examples with examples that are not so big

So the reason that the scoutsuite_sample.json is so big (20MB) is cause it has all the newlines/formatting put into it due to being prettified instead of all being on one line. This file as useful as a development tool but it's not necessary to store in the repo. Furthermore, it's easily reproducible when required (delete the first line and then run it through json formatter of choice).

If I delete that file, is it fine to leave the file we got directly from scoutsuite (4.5MB)? Still an order of magnitude more than the others (nikto/zap) but imo it's useful to have a complete file for testing/development purposes, and it's far less than what it was originally.

I think removing the 20MB file is a great start. I also don't think anyone has tried to get a smaller sample.

Bialogs commented 3 years ago

Looks good. Still looking for a resolution on the 4M sample size & rebase.

ejaronne commented 3 years ago

Drop this sample. It is not an appropriate Sample and takes 20MB. Only the 4MB .js sample is needed. https://github.com/mitre/heimdall_tools/blob/scoutsuite_mapper/sample_jsons/scoutsuite_mapper/sample_input_jsons/scoutsuite_sample.json

Amndeep7 commented 3 years ago

Deleted the files in history and then added the minified versions in af27e72

Amndeep7 commented 3 years ago

Only thing blocking this from being merged is rubocop complaining about the spinner for some reason even though that code is exactly the same as in all the other mappers and it saying that the to_hdf function has too many branches which I always thought was a pretty dumb rule cause stuff happens to be pretty darn conditional.

@Bialogs @rbclark any suggestions on how to get it to pass rubocop?

ejaronne commented 3 years ago

is it possible to merge and release by COB on this please?