search

mitre / heimdall_tools

DEPRECATED: A set of utilities for converting and working with compliance data for viewing in the heimdall applications
https://heimdall-tools.mitre.org
Other
35 stars 20 forks source link

WIP: make HDF file match Inspec #97

Closed Amndeep7 closed 2 years ago

Amndeep7 commented 3 years ago

Make hdf file better match current inspec profile format: https://github.com/inspec/inspec/blob/e2dc3d3cdc879467abe8477cee81a8f7b9ec632f/lib/inspec/reporters/json.rb#L68

Signed-off-by: Amndeep Singh Mann amann@mitre.org

rbclark commented 3 years ago

Since this changes the test data it causes the whole test suite to fail since the output files are actually expected to be different. In order for this to pass you will need to regenerate all of the samples to contain the new fields you added.

aaronlippold commented 3 years ago

Do we need to do anything on this PR?

rbclark commented 3 years ago

Do we need to do anything on this PR?

Yes my previous comment is still unaddressed.