fix: entropy plugin exec and remove legacy plugin handling

mitre / hipcheck

Automatically assess and score software repositories for supply chain risk.

https://mitre.github.io/hipcheck/

Apache License 2.0

80 stars 6 forks source link

fix: entropy plugin exec and remove legacy plugin handling #576

Closed j-lanson closed 2 weeks ago

j-lanson commented 2 weeks ago

Resolves #559 . Resolves #579 .

Updates entropy plugin to run smoothly, and also rips out the MITRE_LEGACY_PLUGINS infrastructure from Hipcheck core, as after this there are no more legacy plugin implementations.

Separate commit adds outbound chunking to hipcheck core and SDK, which was not previously implemented causing too-large gRPC messages to crash the analysis.

Also replaces a lot of println/eprintln calls with log::{warn, error, trace, debug}

patrickjcasey commented 2 weeks ago

I am starting to review this right now! It seems like config/Hipcheck.kdl needs to be updated to provide a manifest path for the entropy plugin

j-lanson commented 2 weeks ago

I am starting to review this right now! It seems like config/Hipcheck.kdl needs to be updated to provide a manifest path for the entropy plugin

@patrickjcasey Good catch, I've updated the file

patrickjcasey commented 2 weeks ago

I am seeing this error when running this branch on the hipcheck repo with the default policy file

It seems that mitre/typo and mitre/edit errors are also occurring on develop

j-lanson commented 2 weeks ago

I am seeing this error when running this branch on the hipcheck repo with the default policy file

As per the PR message, this branch needs the git parser fixes Andrew was working on. Let me rebase off of main now that those fixes are merged.