mitre / hipcheck

Automatically assess and score software repositories for supply chain risk.
https://mitre.github.io/hipcheck/
Apache License 2.0
48 stars 3 forks source link

Make git-cliff a required installation #88

Closed mchernicoff closed 1 month ago

mchernicoff commented 1 month ago

The xtask changelog command requires git-cliff to be installed. This is currently not required or automatically installed by hipcheck. We should have Hipcheck install this at installation time or otherwise document that the user needs to manually install it (preference for the former).

j-lanson commented 1 month ago

git-cliff can be installed via cargo.

@mchernicoff Should this step be part of build.rs or handled separately for Containerfile/install.sh/source building?

mchernicoff commented 1 month ago

If we can get away with putting in the build script, that is probably better just in terms of keeping things simple. I haven't looked into this, but we probably want to do some check to see if git cliff is already installed, so we don't re-install it every time (that may be the default behavior anyway; I haven't really done a lot of work with custom build.rs files myself).