mitre / inspec_tools

A command-line and ruby API of utilities, converters and tools for creating, converting and processing security baseline formats, results and data
https://inspec-tools.mitre.org/
Other
92 stars 30 forks source link

Summary always returns 0 for profile errors #164

Closed rbclark closed 4 years ago

rbclark commented 4 years ago

Profile_Error is no longer a valid element in Checklist Schema v2.2, see issue #131. In order to fix this, inspec2ckl will now output Not_Reviewed for Profile Errors.

https://github.com/mitre/inspec_tools/blob/bd2c1adb6618c5324871d798d1b4b36765c2d892/lib/utilities/inspec_util.rb#L146-L158

The issue is summary.rb uses the count of Profile_Error from parse_data_for_ckl, which now has no codepath to raise Profile_Error. This is caused by a deeper problem with how we currently have abstracted everything (see #165)