search

mitre / inspec_tools

A command-line and ruby API of utilities, converters and tools for creating, converting and processing security baseline formats, results and data
https://inspec-tools.mitre.org/
Other
91 stars 30 forks source link

Remove legacy V and SV identifiers from the CCI tags in xccdf2inspec #221

Closed Bialogs closed 3 years ago

Bialogs commented 3 years ago

Create an additional Ident HappyMapper class and adds an after_parse callback that parses the Ident tag legacy identifier.

Closes #220

Bialogs commented 3 years ago

@aaronlippold Let me know if this works for you. It will remove all of the Ident properties identified by DISA as legacy (which is currently everything except the CCI).

aaronlippold commented 3 years ago

Well we want to make them new tags right

On Mon, Mar 15, 2021 at 5:15 PM Kyle @.***> wrote:

@aaronlippold https://github.com/aaronlippold Let me know if this works for you. It will remove all of the Ident properties identified by DISA as legacy (which is currently everything except the CCI).

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/mitre/inspec_tools/pull/221#issuecomment-799757179, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALK42DLQ2IWPM7QEJE3S2TTDZ2HBANCNFSM4ZHINS4A .

--

Aaron Lippold

@.***

260-255-4779

twitter/aim/yahoo,etc. 'aaronlippold'

rbclark commented 3 years ago

Well we want to make them new tags right On Mon, Mar 15, 2021 at 5:15 PM Kyle @.> wrote: @aaronlippold [@aaronlippold](https://github.com/aaronlippold) Let me know if this works for you. It will remove all of the Ident properties identified by DISA as legacy (which is currently everything except the CCI). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#221 (comment)>, or unsubscribe <github.com/notifications/unsubscribe-auth/AALK42DLQ2IWPM7QEJE3S2TTDZ2HBANCNFSM4ZHINS4A> . -- -------- Aaron Lippold @. 260-255-4779 twitter/aim/yahoo,etc. 'aaronlippold'

Are you saying you want tag legacy: ['v-xxx', 'sv-xxx] to be added to the output? Or something else?

aaronlippold commented 3 years ago

If I remember correctly from my meeting with Disa. They gave us the names of those data points, I just suggest we create tags using those names so that we don’t have any data loss, and we can re-create the file from the profile anytime we need to.

On Tue, Mar 16, 2021 at 8:16 AM Robert Clark @.***> wrote:

Well we want to make them new tags right On Mon, Mar 15, 2021 at 5:15 PM Kyle @. *> wrote: @aaronlippold https://github.com/aaronlippold @.** https://github.com/aaronlippold> Let me know if this works for you. It will remove all of the Ident properties identified by DISA as legacy (which is currently everything except the CCI). — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#221 (comment) https://github.com/mitre/inspec_tools/pull/221#issuecomment-799757179>, or unsubscribe <github.com/notifications/unsubscribe-auth/AALK42DLQ2IWPM7QEJE3S2TTDZ2HBANCNFSM4ZHINS4A https://github.com/notifications/unsubscribe-auth/AALK42DLQ2IWPM7QEJE3S2TTDZ2HBANCNFSM4ZHINS4A> . -- -------- Aaron Lippold @. 260-255-4779 twitter/aim/yahoo,etc. 'aaronlippold'

Are you saying you want tag legacy: ['v-xxx', 'sv-xxx] to be added to the output? Or something else?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/mitre/inspec_tools/pull/221#issuecomment-800210033, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALK42GPJHXY7MT7DVH6WZDTD5D2RANCNFSM4ZHINS4A .

--

Aaron Lippold

@.***

260-255-4779

twitter/aim/yahoo,etc. 'aaronlippold'

rbclark commented 3 years ago

Can you provide an example of what you are expecting the output structure of this to look like in inspec? Currently the XCCDF provides no information on what this additional data is other than the fact that it is in the namespace http://cyber.mil/legacy which doesn't provide much in the way of identification.