mitre / inspec_tools

A command-line and ruby API of utilities, converters and tools for creating, converting and processing security baseline formats, results and data

https://inspec-tools.mitre.org/

Other

92 stars 30 forks source link

Enhancements to meet working with STIGViewer as well as tracking some custom metadata when converting from xccdf2inspec and inspec2ckl #51

Closed kevin-j-smith closed 5 years ago

kevin-j-smith commented 5 years ago

50

https://github.com/inspec/inspec/pull/3885 https://github.com/inspec/train/pull/418

These changes yield enhancements around additional/missing information for what STIGViewer says is a valid checklist as well as add skip_message to the checklist's justification.

kevin-j-smith commented 5 years ago

CodeFactor is complaining that something that has already been fixed. I am not sure how to over-correct the non-issue.

aaronlippold commented 5 years ago

Hi, I updated CodeClimate to ignore that file for now, but I do want @samcornwell and @rx294 to review the PR.

You should be able to do a force push of your PR and with the updates to the .gemspec file and CodeClimate your PR should come back clean.

Also, if we are adding new data into the processes - aka your metadata JSON file - we need to update the Docs and examples as well so we communicate it to the end users.

aaronlippold commented 5 years ago

@kevin-j-smith did you force push your branch and you will need to sign your commit as will via git commit ... -s

aaronlippold commented 5 years ago

Did you commit an example of the metadata.json file?

samcornwell commented 5 years ago

@aaronlippold @kevin-j-smith checking out why this fails some tests

aaronlippold commented 5 years ago

https://github.com/burtlo/ohai/pull/1 https://github.com/burtlo/inspec-ohai_resource

samcornwell commented 5 years ago

@aaronlippold @kevin-j-smith Committed to non-master branch mitre/fix-pr51. Fixed bugs in that branch and then pulled into master (see #52)