mitre / inspec_tools

A command-line and ruby API of utilities, converters and tools for creating, converting and processing security baseline formats, results and data

https://inspec-tools.mitre.org/

Other

91 stars 30 forks source link

add "# encoding: utf-8" to controls #54

Closed ejaronne closed 4 years ago

ejaronne commented 5 years ago

encoding: utf-8

should be added to the top of all controls for "2inspec" tools.

TheLonelyGhost commented 5 years ago

Is this still necessary with modern versions of ruby? Seems this is an artifact of Ruby 1.x in order to support built-in UTF-8 characters, which is EOL'ed.

https://bugs.ruby-lang.org/issues/6679

aaronlippold commented 5 years ago

The challenge we are addressing is windows zip files of the profiles. We have had issues if the encoding isn't in the files for some reason. Is there a better fix?

TheLonelyGhost commented 5 years ago

Honestly I haven't experienced the windows zip file problems of which you speak, so I can't say that I know of a better fix.

Thanks for the additional context though!