search

mitre / inspec_tools

A command-line and ruby API of utilities, converters and tools for creating, converting and processing security baseline formats, results and data
https://inspec-tools.mitre.org/
Other
92 stars 30 forks source link

Fix VERSION file update to update the right file in the gem #79

Closed aaronlippold closed 4 years ago

aaronlippold commented 5 years ago

The standard location for the version information is /lib//version.rb in a gem. There should be semantic versioning gems we can use. The VERSION file ( not a .md file ) should just be a string with the current version in it - aka 1.6.5 in this case.

I think the current version.md the file would be better named release.md

lukemalinowski commented 5 years ago

I dont see a version.md file, just so you know.

djhaynes commented 5 years ago

VERSION.md was changed to RELEASE.md, but, Aaron is referring to lib/inspec_tools/version.rb in this issue.

aaronlippold commented 5 years ago

I think it is in the root directory

Aaron Lippold

lippold@gmail.com

260-255-4779

twitter/aim/yahoo,etc. 'aaronlippold'

On Tue, Nov 5, 2019 at 12:52 PM lukemalinowski notifications@github.com wrote:

I dont see a version.md file, just so you know.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mitre/inspec_tools/issues/79?email_source=notifications&email_token=AALK42DROQRMJSBDR5YI3MTQSGXHJA5CNFSM4JI5NIFKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEDDWINQ#issuecomment-549938230, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALK42FAOMONEQNO6RGSD73QSGXHJANCNFSM4JI5NIFA .

Bialogs commented 4 years ago

The version.yml GitHub action we have actually updates the correct file, but it does not seem to be working correctly within the runner.