Fix production routing and add a not found page

mitre / magma

MITRE Caldera's user interface plugin powered by VueJS

Apache License 2.0

2 stars 6 forks source link

Fix production routing and add a not found page #13

Closed JamieScottC closed 9 months ago

JamieScottC commented 10 months ago

This adds a "404 Not found" page when trying to access a route that doesn't exist.
Also fixes routing in production when trying to access a route directly from the browsers url bar
Also fixes duplicate tab behavior in production when navigating between tabs by clicking on them

Note: This is another one of those changes that requires the latest magma branch on the caldera server

morinjmit commented 10 months ago

Does this have a 404 show up when a user manually tries to navigate to a URL in the address bar? I don't see a 404 showing up but I may be misunderstanding the functionality

morinjmit commented 10 months ago

Also when i have multiple tabs open and i manually enter in the address bar for a route (eeg. localhost:3000/agents) it will close all the tabs except for the one I enter. Not sure if thats desired behavior or not

JamieScottC commented 10 months ago

Does this have a 404 show up when a user manually tries to navigate to a URL in the address bar? I don't see a 404 showing up but I may be misunderstanding the functionality

Yeah that should have a 404 not found message at that route huh. I just committed another catch so maybe that will work.

JamieScottC commented 10 months ago

Also when i have multiple tabs open and i manually enter in the address bar for a route (eeg. localhost:3000/agents) it will close all the tabs except for the one I enter. Not sure if thats desired behavior or not

Yeah unfortunately there's no way to get around that since if a user enters a new route it will reload the entire web page including the javascript which holds the data for which tabs are open.