Fix encoding error in manually approved links

mitre / magma

MITRE Caldera's user interface plugin powered by VueJS

Apache License 2.0

2 stars 6 forks source link

Fix encoding error in manually approved links #49

Closed guillaume-duong-bib closed 2 months ago

guillaume-duong-bib commented 2 months ago

Fixes mitre/caldera#2968

This is a... Very simple fix, maybe too simple, to the point that I'm wondering really hard what I could have missed. Here's my reasoning: I do not discuss the implementation of b64DecodeUnicode, just its usage in this case, because the command that gets passed to updateLink is definitely not encoded in Base64.

With this change on top of mitre/magma#48, I am able to approve links in a manual operations and actually have them work.

elegantmoose commented 2 months ago

Great catch.

elegantmoose commented 2 months ago

Thank you @guillaume-duong-bib !