search

mitre / microsoft-windows-server-2019-stig-baseline

Microsoft Windows Server 2019 STIG InSpec Profile
Other
14 stars 11 forks source link

Input optimization #103

Closed abailey1021 closed 1 year ago

abailey1021 commented 1 year ago

Added changes to reduce number of redundant inputs that were created to paramaterize STIG text. Removed (temporary_account_period_phrase, emergency_account_period_phrase, maximum_idle_time_phrase

resolves #89

abailey1021 commented 1 year ago

Hi Shivani,How do we write the formula for hours/ days? Or do we not need the days any longer? Thanks,AaronOn May 11, 2023, at 7:09 PM, Shivani Karikar @.***> wrote: @karikarshivani commented on this pull request.

In inspec.yml:

  • type: Hash
  • value:
  • hours: 72
  • days: 3

Discussed this with Eugene and we have decided to continue using Numeric for now. We may also need to update the ARS 5.0 overlay but I'll create another issue for that.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

karikarshivani commented 1 year ago

Hi Shivani,How do we write the formula for hours/ days? Or do we not need the days any longer? Thanks,AaronOn May 11, 2023, at 7:09 PM, Shivani Karikar @.***> wrote: @karikarshivani commented on this pull request. In inspec.yml:

  • type: Hash
  • value: + hours: 72 + days: 3 Discussed this with Eugene and we have decided to continue using Numeric for now. We may also need to update the ARS 5.0 overlay but I'll create another issue for that. —Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: @.***>

Hey @abailey1021, similar to the changes you made in V-93509, you can just multiple the input by 24 within the other controls. That will remove the requirement of using a Hash and we can revert to the original data type of Numeric