mitre / microsoft-windows-server-2019-stig-baseline

Microsoft Windows Server 2019 STIG InSpec Profile
Other
14 stars 11 forks source link

V-93283 logic reversed? #8

Closed ejaronne closed 3 years ago

ejaronne commented 3 years ago

https://github.com/mitre/microsoft-windows-server-2019-stig-baseline/blob/peer-review/controls/V-93283.rb

"If \"NewGuestName\" is not something other than \"Guest\" in the file, this is a finding."

Yet the describe block seems to be the reverse?

  describe security_policy do
    its('NewGuestName') { should eq "Guest" }
  end

or am I misunderstanding?

karikarshivani commented 3 years ago

Great catch! The control has now been changed to

describe security_policy do
  its('NewGuestName') { should_not eq "Guest" }
end