mitre / multiscanner

Modular file scanning/analysis framework
http://multiscanner.readthedocs.io/
Other
617 stars 125 forks source link

NSRL out of memory #155

Closed kvozon closed 6 years ago

kvozon commented 6 years ago

Hi, i used the latest master branch, and while running NSRL module on 2GB system, i saw a "out of memory" error thrown by nsrl. I checked the code and the exception is thrown in line 62: line = hash_list.readline().split('\t') I checked the structure of NSRL hash_list file and found out that it doesn't have a new line, so all the file is one liner I checked the utils/nsrl_parse.py file and saw that there is no new line added, but when i checked the history, I saw that it has: output.write('\n') My guess that while merging (commit 3325cb882f228cb0a3ec3c5f2bb8094457e887a2) this line was forgotten. I propose a fix for file utils/nsrl_parse.py: line 81: output.write(line[3]) -> output.write(line[3] + '\n')