Allow executors to update their binary paths

mitre / sandcat

A CALDERA plugin

https://caldera.mitre.org/

Apache License 2.0

61 stars 36 forks source link

Allow executors to update their binary paths #371

Closed uruwhy closed 3 years ago

uruwhy commented 3 years ago

Description

Extension executors can update their binary paths using new executor interface method

Type of change

[x] New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Tested compiling the executor extensions and tested updating executor paths.

Checklist:

[x] My code follows the style guidelines of this project
[x] I have performed a self-review of my own code
[ ] I have made corresponding changes to the documentation
[ ] I have added tests that prove my fix is effective or that my feature works

mrengstrom commented 3 years ago

Is this something we should add to the executor interface and should be required in all implemented executors?

https://github.com/mitre/gocat/blob/fbb28a3ebfe1c305c6220c77c6ea20867bf25bb9/execute/execute.go#L19

uruwhy commented 3 years ago

Is this something we should add to the executor interface and should be required in all implemented executors?

https://github.com/mitre/gocat/blob/fbb28a3ebfe1c305c6220c77c6ea20867bf25bb9/execute/execute.go#L19

This is already in the executor interface for gocat. The PR is to update the gocat extension executors so they comply with the updated interface and compile

mrengstrom commented 3 years ago

This is already in the executor interface for gocat. The PR is to update the gocat extension executors so they comply with the updated interface and compile

Thats what I get for following the subrepo link since it is pinned and not master. I see it there on master, so all looks good!!