mitre / sandcat

A CALDERA plugin
https://caldera.mitre.org/
Apache License 2.0
61 stars 36 forks source link

Gocat Extension UTC Time #383

Closed uruwhy closed 2 years ago

uruwhy commented 2 years ago

Description

Donut and shellcode executors will now report execution timestamps in UTC time

Type of change

How Has This Been Tested?

Tested the executors and confirmed UTC timestamps

Checklist:

emmanvg commented 2 years ago

@uruwhy this is the only place I could find time.Now.UTC() missing:

https://github.com/mitre/sandcat/blob/0852880ff71bea11ee43ed8959cc8a09492856a0/gocat-extensions/execute/donut/donut.go#L69

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

uruwhy commented 2 years ago

@uruwhy this is the only place I could find time.Now.UTC() missing:

https://github.com/mitre/sandcat/blob/0852880ff71bea11ee43ed8959cc8a09492856a0/gocat-extensions/execute/donut/donut.go#L69

Good catch! Fixed