mitre / vulcan

A web application to streamline the development of STIGs from SRGs
https://mitre-vulcan-prod.herokuapp.com/
Other
58 stars 16 forks source link

Enabling SMTP feature to send emails via ActionMailer #584

Closed smarlaku820 closed 1 year ago

smarlaku820 commented 1 year ago

Attaching the sample screenshots

Welcome Email

welcome_user_smtp

Request Review

request_review_smtp

Request Additional Changes

request_review_changes_smtp

Approve Request

approve_review_smtp

Revoke Request

revoke_review_smtp
aaronlippold commented 1 year ago

https://github.com/excid3/noticed?? useful?

smarlaku820 commented 1 year ago

@aaronlippold ,

Thank you for suggesting the library. Although I haven't reviewed it yet, I'm open to considering it since it appears to offer extensive support for various delivery methods, which could be beneficial for our project

vanessuniq commented 1 year ago

https://github.com/excid3/noticed?? useful?

This could solve several delivery methods in one implementation. @smarlaku820 what do you think? I'll try to play with it.

vanessuniq commented 1 year ago

@aaronlippold ,

Thank you for suggesting the library. Although I haven't reviewed it yet, I'm open to considering it since it appears to offer extensive support for various delivery methods, which could be beneficial for our project

@smarlaku820 Should we wait on this PR, try to use the gem Aaron suggested to see how it works out??

aaronlippold commented 1 year ago

I always like it when others work through the hard stuff and push it into a lib for me :)

smarlaku820 commented 1 year ago

@vanessuniq

I haven't got the bandwidth for the next couple of weeks. Maybe, I will take a look at the lib after that.