search

mitre / vulcan

A web application to streamline the development of STIGs from SRGs
https://mitre-vulcan-prod.herokuapp.com/
Other
60 stars 16 forks source link

Constrain the selectable list to allow only Apllicable - Configurable controls to be satisfied by other #586

Closed vanessuniq closed 1 year ago

freddyfeelgood commented 1 year ago

Hey Vanessa, this logic seems almost "backwards" to me... What should happen is that only "Applicable - Configurable" controls can be "parents", and then creating a "satisfies" link to another requirement automatically makes that "child" requirement assume the "Applicable - Configurable" status.

Before, when the "Mark as Duplicate" button was there, the action was taken on the "Child" requirement, so it would make sense to filter the list to only "AC" items, because that would become the "parent".

Now, because the "Add+" action is taken from the "parent" item, I think the list should contain basically everything. However, the "Add+" button should probably only be visible on items with a status of "AC" that are not "children" to other items.

@rlakey, thoughts?

rlakey commented 1 year ago

Hey Vanessa, this logic seems almost "backwards" to me... What should happen is that only "Applicable - Configurable" controls can be "parents", and then creating a "satisfies" link to another requirement automatically makes that "child" requirement assume the "Applicable - Configurable" status.

Before, when the "Mark as Duplicate" button was there, the action was taken on the "Child" requirement, so it would make sense to filter the list to only "AC" items, because that would become the "parent".

Now, because the "Add+" action is taken from the "parent" item, I think the list should contain basically everything. However, the "Add+" button should probably only be visible on items with a status of "AC" that are not "children" to other items.

@rlakey, thoughts?

You're right and I wasn't as clear as I could have been in the issue I opened on this and probably mixed in the old and new behavior from the UI updates. It came up because I was fixing some items that we had marked as satisfied by but the parent was later changed to N/A or something else not configurable. Maybe the thing here, like you said, is to only show the add button on configurable items.

vanessuniq commented 1 year ago

Now the Add button only appears on Applicable - Configurable controls.