mitre / vulcan

A web application to streamline the development of STIGs from SRGs
https://mitre-vulcan-prod.herokuapp.com/
Other
58 stars 16 forks source link

VULCAN-528: Fix component admin on component cards #588

Closed vanessuniq closed 11 months ago

vanessuniq commented 1 year ago

Fix #528

vanessuniq commented 1 year ago

Ready for review

freddyfeelgood commented 1 year ago

In testing, if I edit an existing component, then in the dropdown I am only presented with users who have the admin role explicitly on the project (not even Vulcan admins show up, unless added to the project as an admin).

If I use the "Copy Component" or the "Create New Component" button, however, then I am presented with a full list of all users on the project, regardless of role (still no Vulcan admins).

Maybe for a future discussion, but I think my preference would be any user on the project could be set as the PoC, regardless of role? And only admins of the project (or Vulcan admins) can edit that field?

vanessuniq commented 1 year ago

In testing, if I edit an existing component, then in the dropdown I am only presented with users who have the admin role explicitly on the project (not even Vulcan admins show up, unless added to the project as an admin).

If I use the "Copy Component" or the "Create New Component" button, however, then I am presented with a full list of all users on the project, regardless of role (still no Vulcan admins).

Maybe for a future discussion, but I think my preference would be any user on the project could be set as the PoC, regardless of role? And only admins of the project (or Vulcan admins) can edit that field?

Nice catch! That's actually a good point. I will update the list to all member of the given project & will see what other think

vanessuniq commented 1 year ago

updated the selection list to be all member of the components