search

mitreid-connect / OpenID-Connect-Java-Spring-Server

An OpenID Connect reference implementation in Java on the Spring platform.
Other
1.47k stars 767 forks source link

Update mysql-connector to 8.0.13 #1495

Open col-panic opened 4 years ago

col-panic commented 4 years ago

As mentioned in https://github.com/mitreid-connect/OpenID-Connect-Java-Spring-Server/issues/1494 - I need to be able to connect to newer mysql databases, which is not possible given the old version of mysql.

I built the patched version locally and applied the overlay on it.

The resulting product runs as required, now delivering some (cosmetic) warnings on startup. Removing those warnings should required some source changes.

Loading class `com.mysql.jdbc.Driver'. This is deprecated. The new driver class is `com.mysql.cj.jdbc.Driver'. The driver is automatically registered via the SPI and manual loading of the driver class is generally unnecessary.
...
[EL Info]: 2019-07-09 09:52:49.384--ServerSession(2141526452)--EclipseLink, version: Eclipse Persistence Services - 2.7.4.v20190115-ad5b7c6b2a
[EL Info]: connection: 2019-07-09 09:52:49.917--ServerSession(2141526452)--/file:/private/var/folders/rq/bwqzcstj45lbsxj83v189jg40000gn/T/jetty-0.0.0.0-8380-openid.war-_openid-any-3436388020107941948.dir/webapp/WEB-INF/lib/openid-connect-common-1.3.4-SNAPSHOT.jar_defaultPersistenceUnit login successful
[EL Info]: 2019-07-09 09:52:49.999--ServerSession(1782136855)--EclipseLink, version: Eclipse Persistence Services - 2.7.4.v20190115-ad5b7c6b2a
WARN : com.zaxxer.hikari.util.DriverDataSource - Registered driver with driverClassName=com.mysql.jdbc.Driver was not found, trying direct instantiation.
[EL Info]: connection: 2019-07-09 09:52:50.158--ServerSession(1782136855)--/bundleresource://60.fwk1403704789/_elexisPersistenceUnit login successful
codecov-io commented 4 years ago

Codecov Report

Merging #1495 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1495   +/-   ##
=========================================
  Coverage     25.21%   25.21%           
  Complexity      912      912           
=========================================
  Files           209      209           
  Lines         11689    11689           
  Branches       2116     2116           
=========================================
  Hits           2947     2947           
  Misses         8227     8227           
  Partials        515      515

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cc6bd4b...81c1e0e. Read the comment docs.